Skip to content

[18.0][REF] base_cancel_confirm: split method to update value in docs #1169

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: 18.0
Choose a base branch
from
Open

[18.0][REF] base_cancel_confirm: split method to update value in docs #1169

wants to merge 1 commit into from

Conversation

@Saran440
Copy link
Member

@Saran440 Saran440 commented Oct 15, 2025

This PR split method to allow other module update values docs.

@OCA-git-bot
Copy link
Contributor

OCA-git-bot commented Oct 15, 2025

Hi @kittiu,
some modules you are maintaining are being modified, check this out!

@Saran440 Saran440 force-pushed the 18.0-fix-base_cancel_confirm-split_hook_update branch from 3b7541f to 066f4ec Compare October 15, 2025 10:24
@Saran440 Saran440 mentioned this pull request Oct 15, 2025
Open
1 task
@Saran440 Saran440 force-pushed the 18.0-fix-base_cancel_confirm-split_hook_update branch from 066f4ec to 05c6bef Compare October 15, 2025 11:11
@Saran440 Saran440 mentioned this pull request Oct 15, 2025
Open
2 tasks
StefanRijnhart
StefanRijnhart reviewed Nov 5, 2025
View reviewed changes
Copy link
Member

@StefanRijnhart StefanRijnhart left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor nag: more a [REF] than a [FIX], or is there a faulty behavior that can already be observed with using only OCA modules?

@Saran440 Saran440 changed the title [18.0][FIX] base_cancel_confirm: split method to update value in docs [18.0][REF] base_cancel_confirm: split method to update value in docs Nov 6, 2025
@Saran440
Copy link
Member Author

Saran440 commented Nov 6, 2025 •
edited
Loading

@StefanRijnhart Thank you for your feedback. I've changed the name to [REF]. This PR only splits the method, no functional change.

StefanRijnhart
StefanRijnhart approved these changes Nov 6, 2025
View reviewed changes
Copy link
Member

@StefanRijnhart StefanRijnhart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

TheerayutEncoder
TheerayutEncoder approved these changes Nov 7, 2025
View reviewed changes
Copy link
Member

@TheerayutEncoder TheerayutEncoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍
Thanks for your work.

@OCA-git-bot
Copy link
Contributor

OCA-git-bot commented Nov 7, 2025

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

1 similar comment
@OCA-git-bot
Copy link
Contributor

OCA-git-bot commented Nov 7, 2025

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@StefanRijnhart StefanRijnhart StefanRijnhart approved these changes

+1 more reviewer

@TheerayutEncoder TheerayutEncoder TheerayutEncoder approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

approved ready to merge

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Saran440 @OCA-git-bot @StefanRijnhart @TheerayutEncoder